[Cocci] Compacting parameters into fewer lines

Timur Tabi ttabi at nvidia.com
Thu Aug 2 22:32:11 CEST 2018


On 08/01/2018 01:08 AM, SF Markus Elfring wrote:

> Do you care if a macro (or function) parameter is optionally enclosed by parentheses?

It's not optional.  The calls to DBG_PRINTF use double parens, and need 
to be replaced with single parens when using NV_PRINTF.

>> -        DBG_PRINTF((DBG_MODULE_OS, DEBUGLEVEL_ERRORS,
>> -            "NVRM: x86emu: int $%d (eax = %08x)\n", num, M.x86.R_EAX));
>> +        NV_PRINTF();
> 
> Does this test result need any further clarification for the desired
> software behaviour on an other change granularity?

I don't understand that.

The purpose of the script is to convert

DBG_PRINTF((DBG_MODULE_OS, DEBUGLEVEL_ERRORS, "NVRM: x86emu: int $%d 
(eax = %08x)\n", num, M.x86.R_EAX));

into

NV_PRINTF(LEVEL_ERRORS, "x86emu: int $%d (eax = %08x)\n", num, M.x86.R_EAX);

> How do you think about to improve the replacement specification a bit more
> by combining the variants A  till D into a single SmPL rule which will use
> a nested SmPL disjunction?

I don't know what a "nested SmPL disjunction" is.
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------


More information about the Cocci mailing list