[Cocci] [PATCH] coccinelle: api: detect duplicate chip data arrays

Julia Lawall julia.lawall at lip6.fr
Thu Oct 5 21:58:23 CEST 2017



On Thu, 5 Oct 2017, Joe Perches wrote:

> On Thu, 2017-10-05 at 12:46 -0700, Liam Breck wrote:
> > Hi Joe,
> >
> > On Thu, Oct 5, 2017 at 12:30 PM, Joe Perches <joe at perches.com> wrote:
> > > On Thu, 2017-10-05 at 21:19 +0200, Julia Lawall wrote:
> > > > On Thu, 5 Oct 2017, Joe Perches wrote:
> > > > > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote:
> > > > > > On Fri, 6 Oct 2017, Masahiro Yamada wrote:
> > > > > > > 2017-10-01 21:42 GMT+09:00 Julia Lawall <Julia.Lawall at lip6.fr>:
> > > > > > > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA
> > > > > > > > within a single structure.  It is currently specific to the file
> > > > > > > > drivers/power/supply/bq27xxx_battery.c.
> > > > > > > > Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>
> > > > > > >
> > > > > > > Applied to linux-kbuild/misc.
> > > > > >
> > > > > > Thanks for picking it up.
> > > > >
> > > > > If it is specific to one file, why not just run it
> > > > > and post the resultant patch?  Why have it in tree?
> > > >
> > > > I guess that they anticipate that the data may change in the future?
> > >
> > > Aren't you the script author Julia?  Who is the "they"?
> > >
> > > I think having a script for a single file unnecessary.
> >
> > Sebastian Reichel, the power-supply maintainer, requested this script.
> > I previously implemented this as a run-time check within ifdef DEBUG,
> > but that was rejected.
>
> Hi Liam.
>
> If you are the author of the script, you should also have
> a sign-off/from here right?
>
> This also has a copyright of Inria and Julia Lawall
> which, if you are the author, doesn't seem appropriate.

I am the author.  Liam and Sebastian asked for it to be done and to be put
into the kernel.

julia


More information about the Cocci mailing list