[Cocci] Question about a not made change

Julia Lawall julia.lawall at lip6.fr
Sat Nov 25 08:44:27 CET 2017



On Sat, 25 Nov 2017, Francois-Xavier Le Bail wrote:

> Hi,
>
> I try the following patch:
> -----
> @@
> u_char *p;
> expression n;
> @@
> ND_PRINT(
> ...,
> -p[n]
> +EXTRACT_U_1(p + n)
>  )
> -----
> on the following (minimized) code:
> -----
> int main()
> {
>         u_char *p;
>         ND_PRINT(ndo, ": %02x %02x", p[1], p[2]);
>
>         return 0;
> }
> -----
> I got:
> -----
> +++ /tmp/cocci-output-1795-a34831-main.c
> @@ -1,7 +1,7 @@
>  int main()
>  {
>         u_char *p;
> -       ND_PRINT(ndo, ": %02x %02x", p[1], p[2]);
> +       ND_PRINT(ndo, ": %02x %02x", p[1], EXTRACT_U_1(p + 2));
>
>         return 0;
>  }
> -----
> Why the first p[1] is not change to EXTRACT_U_1(p + 1)?
>
> Did I miss something obvious?

Yes :)  There is no ,... after your change, so you only perform the change
when it is the last argument.

julia

>
> --
> Francois-Xavier
> _______________________________________________
> Cocci mailing list
> Cocci at systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>


More information about the Cocci mailing list