[Cocci] Question about a not made change

Francois-Xavier Le Bail devel.fx.lebail at orange.fr
Sat Nov 25 08:38:09 CET 2017


Hi,

I try the following patch:
-----
@@
u_char *p;
expression n;
@@
ND_PRINT(
...,
-p[n]
+EXTRACT_U_1(p + n)
 )
-----
on the following (minimized) code:
-----
int main()
{
        u_char *p;
        ND_PRINT(ndo, ": %02x %02x", p[1], p[2]);

        return 0;
}
-----
I got:
-----
+++ /tmp/cocci-output-1795-a34831-main.c
@@ -1,7 +1,7 @@
 int main()
 {
        u_char *p;
-       ND_PRINT(ndo, ": %02x %02x", p[1], p[2]);
+       ND_PRINT(ndo, ": %02x %02x", p[1], EXTRACT_U_1(p + 2));

        return 0;
 }
-----
Why the first p[1] is not change to EXTRACT_U_1(p + 1)?

Did I miss something obvious?

-- 
Francois-Xavier


More information about the Cocci mailing list