[Cocci] [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define
gregkh at linuxfoundation.org
Wed Nov 22 18:12:01 CET 2017
On Wed, Nov 22, 2017 at 09:05:36AM -0800, Joe Perches wrote:
> On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote:
> > There is no need to #define the license of the driver, just put it in
> > the MODULE_LICENSE() line directly as a text string.
> > This allows tools that check that the module license matches the source
> > code license to work properly, as there is no need to unwind the
> > unneeded dereference.
> > diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
> > @@ -76,7 +76,6 @@
> > #define MOD_AUTHOR "Option Wireless"
> > #define MOD_DESCRIPTION "USB High Speed Option driver"
> > -#define MOD_LICENSE "GPL"
> > #define HSO_MAX_NET_DEVICES 10
> > #define HSO__MAX_MTU 2048
> > @@ -3288,7 +3287,7 @@ module_exit(hso_exit);
> > MODULE_AUTHOR(MOD_AUTHOR);
> > MODULE_DESCRIPTION(MOD_DESCRIPTION);
> > -MODULE_LICENSE(MOD_LICENSE);
> > +MODULE_LICENSE("GPL");
> Probably all of these MODULE_<FOO>(MOD_<BAR>) uses could be
> simplified as well.
Agreed, I did that for a bunch of USB drivers, need to do it for others
More information about the Cocci