[Cocci] [PATCH v3] coccinelle: fix parallel build with CHECK=scripts/coccicheck

Julia Lawall julia.lawall at lip6.fr
Tue Nov 14 12:09:29 CET 2017



On Tue, 14 Nov 2017, Masahiro Yamada wrote:

> Hi Julia,
>
>
> 2017-11-14 18:49 GMT+09:00 Julia Lawall <julia.lawall at lip6.fr>:
> >> +
> >> +    # If -j option is given to Make, scripts/coccicheck runs in parallel.
> >> +    # If coccinelle also runs in parallel, it fails because multiple processes
> >> +    # try to get access to the same subdirectory that stores stdout/stderr.
> >> +    # No need to parallelize coccinelle in this case - this mode takes only
> >> +    # one file input.
> >> +    NPROC=1
> >
> > Since I am also changing Coccinelle to avoid the problem, maybe it would
> > be better to just remove the explanation sentence (If coccinelle also runs
> > in parallel,...).
> >
> > julia
>
> OK.  Which lines are unneeded?
>
> Is it OK to remove all the comments, then just add "NPROC=1"?

How about keeping "# No need to parallelize coccinelle in this case - this
mode takes only one file input."?

But if you think it is obvious, it would be ok to remove it also.  Someone
can always do git blame and read the commit message if they have
questions.

julia


More information about the Cocci mailing list