[Cocci] [PATCH v2 01/31] coccinelle: Improve setup_timer.cocci matching

Masahiro Yamada yamada.masahiro at socionext.com
Tue Nov 7 01:18:31 CET 2017


2017-09-24 5:43 GMT+09:00 Julia Lawall <julia.lawall at lip6.fr>:
>
>
> On Wed, 20 Sep 2017, Kees Cook wrote:
>
>> This improves the patch mode of setup_timer.cocci. Several patterns
>> were missing:
>>  - assignments-before-init_timer() cases
>>  - limit the .data case removal to the specific struct timer_list instance
>>  - handling calls by dereference (timer->field vs timer.field)
>>
>> Cc: Julia Lawall <Julia.Lawall at lip6.fr>
>> Cc: Gilles Muller <Gilles.Muller at lip6.fr>
>> Cc: Nicolas Palix <nicolas.palix at imag.fr>
>> Cc: Michal Marek <mmarek at suse.com>
>> Cc: cocci at systeme.lip6.fr
>> Signed-off-by: Kees Cook <keescook at chromium.org>
>
> Acked-by: Julia Lawall <julia.lawall at lip6.fr>
>
> Note that I proposed some changes on this rule as well, on August 23
> (https://systeme.lip6.fr/pipermail/cocci/2017-August/004386.html).  My
> changes are still orthogonal to the ones proposed here.
>
> Actually, my changes are in the part about matching, and this patch on
> covers the -D patch case (transformation).  The matching rules should be
> extended in the same way that the patch rules are extended below, but it
> would be better to apply my patch first.
>
> julia
>

Applied to linux-kbuild/misc


-- 
Best Regards
Masahiro Yamada


More information about the Cocci mailing list