[Cocci] [RESEND PATCH 1/1] Coccinelle: array_size: report even if include is missing

Julia Lawall julia.lawall at lip6.fr
Fri Dec 29 19:22:29 CET 2017



On Fri, 29 Dec 2017, Jérémy Lefaure wrote:

> Rule r does not depend on rule i (which is the include of
> linux/kernel.h) so the output should not depend on i in
> org and report mode.
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure at lse.epita.fr>
> Acked-by: Julia Lawall <julia.lawall at lip6.fr>

Re-Acked-by: Julia Lawall <julia.lawall at lip6.fr>


> ---
>
>  scripts/coccinelle/misc/array_size.cocci | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccinelle/misc/array_size.cocci b/scripts/coccinelle/misc/array_size.cocci
> index 6ec05710b017..09520f0941f0 100644
> --- a/scripts/coccinelle/misc/array_size.cocci
> +++ b/scripts/coccinelle/misc/array_size.cocci
> @@ -72,13 +72,13 @@ position p;
>   (sizeof(E)@p /sizeof(T))
>  )
>
> - at script:python depends on i&&org@
> + at script:python depends on org@
>  p << r.p;
>  @@
>
>  coccilib.org.print_todo(p[0], "WARNING should use ARRAY_SIZE")
>
> - at script:python depends on i&&report@
> + at script:python depends on report@
>  p << r.p;
>  @@
>
> --
> 2.14.1
>
>


More information about the Cocci mailing list