[Cocci] modifying array initializers?

Julia Lawall julia.lawall at lip6.fr
Fri Apr 21 21:32:06 CEST 2017



On Fri, 21 Apr 2017, Johannes Berg wrote:

> On Fri, 2017-04-21 at 16:07 +0200, Julia Lawall wrote:
> >
> > Just add ..., here (note the comma at the end).
>
> I thought I tried that, but maybe not. It doesn't work - at least in my
> version - though:
>
> HANDLING: net/wireless/nl80211.c
>      
> previous modification:
>
>   <<< static int wrap_fn(struct sk_buff *skb, struct genl_info *info)
>   <<< {
>   <<< return fn(skb, info);
>   <<< }
>   <<< 
> CONTEXT
> According to environment 2:
>    rule starting on line 1.wrap_fn -> id _wrap_nl80211_wiphy_netns
>    rule starting on line 1.fn -> id nl80211_wiphy_netns
>
> current modification:
>
>   <<< static int wrap_fn(struct sk_buff *skb, struct genl_info *info)
>   <<< {
>   <<< return fn(skb, info);
>   <<< }
>   <<< 
> CONTEXT
> According to environment 2:
>    rule starting on line 1.wrap_fn -> id _wrap_nl80211_vendor_cmd
>    rule starting on line 1.fn -> id nl80211_vendor_cmd
>
> Fatal error: exception Failure("rule starting on line 1: already tagged
> fake token\n")
>
>
> Sounds like it doesn't like to add multiple things here, let me think
> about how to work around that.

If you don't find a solution, send back the rule and the code that causes
trouble, and I will take a look.

julia


More information about the Cocci mailing list