[Cocci] [patch 119/197] scripts/coccinelle/free: Delete NULL test before freeing functions

SF Markus Elfring elfring at users.sourceforge.net
Wed May 6 15:45:23 CEST 2015


>>> + at r depends on context || report || org @
>>> +expression E;
>>> +position p;
>>> +@@
>>> +
>>> +* if (E)
>>> +*	\(kfree at p\|debugfs_remove at p\|debugfs_remove_recursive at p\|usb_free_urb\)(E);
>>
>> How do you think about to add the construct "@p" also behind the function name
>> "usb_free_urb"?
> 
> Yes, that would be needed, thanks.  Also, it was recently suggested to add 
> of_node_put to the list of things that are checked for.

Would you like to achieve further improvements for this approach?
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/scripts/coccinelle/free/ifnullfree.cocci?id=refs/tags/v4.0.1#n34

Regards,
Markus



More information about the Cocci mailing list