[Cocci] sgen problems

Julia Lawall julia.lawall at lip6.fr
Sat Oct 18 08:02:00 CEST 2014


> @fix1_context depends on match1 && !patch && (context || org || report)@
> identifier match1.__driver;
> position j0;
> @@
> 
> * 	static struct platform_driver __driver at j0 = {
> 		.driver = {
> 			.owner = THIS_MODULE,
> 		}
> 	};
> 
> @fix2_context depends on match2 && !patch && (context || org || report)@
> identifier match2.__driver;
> position j0;
> @@
> 
> * 	static struct platform_driver __driver at j0 = {
> 		.driver = {
> 			.owner = THIS_MODULE,
> 		}
> 	};

In these cases, I think it would look nicer to put the *s and the @j0's 
on .owner rather than at the start of the structure.

Unless there is some situation in which the transformation is not 
required, I think High confidence would be appropriate.

julia


More information about the Cocci mailing list