[Cocci] string parameter concatenation

Julia Lawall julia.lawall at lip6.fr
Mon Oct 6 12:49:52 CEST 2014



On Mon, 6 Oct 2014, Cyril Hrubis wrote:

> Hi!
> > > I've found a small nit in the handling of strings that spans over
> > > multiple lines:
> > >
> > > nit.c:
> > > int main(void)
> > > {
> > >         f("This is a string that continues to the next line"
> > >           " just string continuation");
> > > }
> >
> > The patch below solves this problem as well as the one with the long
> > string in the argument list.
>
> It's better but it produces changes like this:
>
> @@ -250,9 +250,14 @@ void l_seek(int fdesc, off_t offset, int whence, off_t checkoff)
>         off_t offloc;
>
>         if ((offloc = lseek(fdesc, offset, whence)) != checkoff) {
> -               tst_resm(TFAIL, "(%ld = lseek(%d, %ld, %d)) != %ld) errno = %d",
> -                        offloc, fdesc, offset, whence, checkoff, errno);
> -               tst_exit();
> +               tst_brkm(TFAIL, NULL,
> +                        "(%ld = lseek(%d, %ld, %d)) != %ld) errno = %d",
> +                        offloc,
> +                        fdesc,
> +                        offset,
> +                        whence,
> +                        checkoff,
> +                        errno);
>         }
>  }
>
> Which seems to be waste of vertical space to me.

Ah.  Indeed.  Thanks for the report.  I will look into it.  Some counter
must not be getting reset.

julia


More information about the Cocci mailing list