[Cocci] [PATCH 1/1] kernel-audit: Deletion of an unnecessary check before the function call "audit_log_end"
SF Markus Elfring
elfring at users.sourceforge.net
Mon Nov 17 09:56:22 CET 2014
> You removed the statement from "if (foo) kfree_fsm(foo);" so now it
> prints a warning.
Would it be better to continue the clarification of affected implementation details
under the discussion topic "s390/net: Deletion of unnecessary checks before two function calls"?
>> It is an usual software development challenge to decide on the best source code places
>> where to put input parameter validation (and when it can be omitted), isn't it?
> No, it's not. You should just try to write the most readable software
> you can instead of removing if statements because you can.
Additional safety checks have also got an effect on source code readability, haven't they?
More information about the Cocci