[Cocci] RFC - simple scanners and matching macros

Nicholas Mc Guire der.herr at hofr.at
Wed Dec 24 10:50:52 CET 2014


On Wed, 24 Dec 2014, Julia Lawall wrote:

> 
> 
> On Wed, 24 Dec 2014, Nicholas Mc Guire wrote:
> 
> > On Wed, 24 Dec 2014, Julia Lawall wrote:
> >
> > > > will update to rc23 and retest - can this be a config/python version issue ?
> > > > python version is 2.7.3 (Debian 7.6)
> > >
> > > I have Python 2.7.5+
> > >
> > > > > For the performance problem, could you send the current semantic patch
> > > > > again, so I could be sure to be testing the right thing?
> > > > >
> > > > files where this situation exists in linux-next (3.18.0) and which should
> > > > trigger are:
> > > >
> > > >  drivers/macintosh/ams/ams-pmu.c        line 52
> > > >  drivers/misc/sgi-gru/grukservices.c    line 1044
> > > >  drivers/scsi/aha152x.c                 line 1055
> > > >  drivers/usb/gadget/udc/fsl_qe_udc.c    line 2630
> > > >  drivers/usb/gadget/udc/fsl_udc_core.c  line 2529
> > >
> > > I tried these files in their linux-next versions with the -D report option
> > > and got an answer more or less immediately (2 seconds).  An example command
> > > line is:
> > >
> > > spatch --sp-file dc.cocci -D report /var/linuxes/linux-next/drivers/scsi/aha152x.c
> > >
> > > Does this work for you?
> > >
> >
> > for the single file it returns more or less imediately but it does not
> > report any findings
> 
> I get a result:
> 
> /var/linuxes/linux-next/drivers/scsi/aha152x.c:1058:1-19: WARNING:
> possible incorrect use of DECLARE_COMPLETION
>

with 1.0.0-rc23 I get the expected results ! both report and patch mode
1.0.0-rc21 no output.

is it worth rebuilding -rc21 to confirm that its in -rc21 and not
some local screwup or is this not relevant ?

thanks a lot for your support on this !

thx!
hofrat 


More information about the Cocci mailing list