[Cocci] [PATCH v2] fs-fat: Less function calls in fat_fill_super() after error detection

Dan Carpenter dan.carpenter at oracle.com
Tue Dec 2 08:34:41 CET 2014


On Mon, Dec 01, 2014 at 10:22:38PM +0100, SF Markus Elfring wrote:
> >> Which names would be better acceptable for you?
> > 
> > You named it after the goto location but the label name should be based
> > on the label location to say what the goto does.
> 
> I find it easier occasionally to name a label similarly to the jump target.

That is a useless thing to do.

> It seems that there are a few variations used for the affected identifiers.

There is a lot of crap code in the kernel, yes.

regards,
dan carpenter



More information about the Cocci mailing list