[Cocci] [PATCH v2] fs-fat: Less function calls in fat_fill_super() after error detection

Dan Carpenter dan.carpenter at oracle.com
Mon Dec 1 20:17:23 CET 2014


On Mon, Dec 01, 2014 at 04:30:44PM +0100, SF Markus Elfring wrote:
> > Meanwhile Markus's error labels are absolutely useless.  They give no
> > indication of what going to the label does.
> 
> Which names would be better acceptable for you?

You named it after the goto location but the label name should be based
on the label location to say what the goto does.  Something like
"err_put_fsinfo", "err_put_fat", and "err_unload" or like that.

regards,
dan carpenter



More information about the Cocci mailing list