[Cocci] [PATCH] compat/compat-drivers/linux-next: fb skip_vt_switch

Luis R. Rodriguez mcgrof at do-not-panic.com
Fri Mar 29 08:29:44 CET 2013


On Thu, Mar 28, 2013 at 11:21 PM, Julia Lawall <julia.lawall at lip6.fr> wrote:
>> > I looked in today's linux-next, and there seems to be only one
>> > initialization of this field, to true, and one test of this field.  So
>> > perhaps the case for setting the field to false just isn't needed.
>>
>> Oh sorry now I get what you mean! I thought about this -- and yes I
>> decided to not add a bool false setting for the structure field given
>> that the assumption is this would not be something dynamic, and data
>> structure would be kzalloc()'d so by default they are 0.
>
> What do you do about the test, though?

Return the value.

  Luis


More information about the Cocci mailing list