[Cocci] 1.0.0-rc16: Further fine-tuning for the build system?

SF Markus Elfring elfring at users.sourceforge.net
Thu Mar 7 18:07:43 CET 2013


> Does it work as it is supposed to be?

It seems that the desired build configuration works also as expected on my
system with an out-of-source build after a small adjustment for a variable.
www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Build-Directories.html

diff --git a/configure.ac b/configure.ac
index 2f0f682..4905af0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8,7 +8,7 @@ AC_CONFIG_MACRO_DIR([setup])
 AC_CONFIG_AUX_DIR([setup])
 AC_SUBST([CONFIGURE_FLAGS], ["$*"])
 AC_SUBST([COCCI_VERSION], ["$PACKAGE_VERSION"])
-AC_SUBST([COCCI_SRCDIR], ["$(pwd)"])
+AC_SUBST([COCCI_SRCDIR], ["$srcdir"])
 AC_MSG_NOTICE([configuring coccinelle $COCCI_VERSION in $COCCI_SRCDIR])
 AM_INIT_AUTOMAKE


I have got the impression that there are more update candidates to consider
since the macro call "AM_INIT_AUTOMAKE" was added.
https://github.com/coccinelle/coccinelle/blob/abad11c5570b7b9bbae5ff92b3050cf68fe3fd14/configure.ac#L13

- Would you like to drop the variable "COCCI_SRCDIR" eventually (because there
is a standard one available)?
- How do you think about to change comments in files like "Makefile.am"?

Regards,
Markus



More information about the Cocci mailing list